-
-
Notifications
You must be signed in to change notification settings - Fork 54
Use Github Actions + cibuildwheel for all wheels #163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
AppVeyor was running the tests, should GHA run tests too?
And can .travis.yml
be removed?
.github/workflows/build.yml
Outdated
|
||
on: | ||
push: | ||
branches: [master] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend removing this branch restriction, so contributors can test their feature branches before opening PRs.
Relatedly, do you have an example build?
Co-authored-by: Hugo van Kemenade <[email protected]>
Thanks for the feedback! Example build here: https://github.com/hauntsaninja/typed_ast/actions/runs/1327600384 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
It's also possible to upload the sdist+wheels to PyPI as part of a release (e.g. tag) using something like https://github.com/pypa/gh-action-pypi-publish, but I'd suggest leaving that for a followup and making a release first with this.
Besides reducing the number of places wheels end up, cibuildwheel does nice things like run auditwheel for you. We also run check-manifest so our sdist is more reliably packaged. Updates to documentation.