Skip to content

PEP 544: correct comments on assignments to protocol-hinted targets #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chepner
Copy link

@chepner chepner commented Feb 9, 2023

Fix comments on a pair of protocol-hinted assignment.

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

Fix comments on a pair of protocol-hinted assignment.
@ghost
Copy link

ghost commented Feb 9, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@JelleZijlstra
Copy link
Member

The example is correct. See #2332.

@JelleZijlstra JelleZijlstra changed the title PEP 504: correct comments on assignments to protocol-hinted targets PEP 544: correct comments on assignments to protocol-hinted targets Feb 9, 2023
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Feb 10, 2023

Considering this keeps confusing people and getting reported/attempted to be changed, it might be worth adding a comment to explicitly clarify this and avoid future such reports/PRs, as discussed in #2332

@ilevkivskyi
Copy link
Member

Yes, if someone will make a PR with a comment as discussed I will take a look.

@CAM-Gerlach
Copy link
Member

@chepner would you like to do so, per the result of the discussion in #2332?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants