Skip to content

PEP 544: Replace broken link to Zope documentation #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2022
Merged

PEP 544: Replace broken link to Zope documentation #2350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efd1825
PEP 544: Replace broken link to Zope documentation
aphedges Feb 20, 2022
5a7281c
PEP 544: Replace bare URL with descriptive text
aphedges Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pep-0544.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,7 +1377,8 @@ Support adapters and adaptation
-------------------------------

Adaptation was proposed by :pep:`246` (rejected) and is supported by
``zope.interface``, see https://docs.zope.org/zope.interface/adapter.html.
``zope.interface``, see `the Zope documentation on adapter registries
<https://web.archive.org/web/20160802080957/https://docs.zope.org/zope.interface/adapter.html>`_.
Comment on lines +1380 to +1381
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an archive link is probably a good idea here, but if the current version of the document is of interest, it is at https://github.com/zopefoundation/zope.interface/blob/master/docs/adapter.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, but I did mention the deployed version of that page in the PR description:

I also found https://zopeinterface.readthedocs.io/en/latest/adapter.html, which contains very similar content

Adapters is quite an advanced concept, and :pep:`484` supports unions and
generic aliases that can be used instead of adapters. This can be illustrated
with an example of ``Iterable`` protocol, there is another way of supporting
Expand Down