-
-
Notifications
You must be signed in to change notification settings - Fork 37
Add tests and enable travis #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The travis was tested on my fork at https://travis-ci.org/msullivan/mypy_extensions, but needs an admin to enable it on the python org. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You can either merge this version, or try the typing settings (I would prefer the latter, but this not a strong preference).
- tox --notest | ||
|
||
script: | ||
- tox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a "runtime" package, I would rather use the Travis settings from python/typing
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which things from typing do you prefer? Is it just running on a bunch more versions, or do you want to not use tox?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually both (but first is probably more important).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason to avoid tox? (I don't have any real opinion one way or another except that the tox version works already :P)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just don't want to learn something the need for what I don't understand. But since it already works, then OK.
- tox --notest | ||
|
||
script: | ||
- tox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just don't want to learn something the need for what I don't understand. But since it already works, then OK.
The tests (and a bunch of the config) is pulled in from mypy