Skip to content

runtests.py: list tests to run in typeshed CI #9638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2020
Merged

runtests.py: list tests to run in typeshed CI #9638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7206d5a
runtests.py: add tests to run in typeshed CI
Oct 25, 2020
6b2dc28
remove typeshed-ci from DEFAULT_COMMANDS
Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion runtests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@
MYPYC_EXTERNAL,
MYPYC_COMMAND_LINE,
ERROR_STREAM]),
# Test cases to run in typeshed CI
'typeshed-ci': 'pytest -k "%s"' % ' or '.join([CMDLINE, EVALUATION, SAMPLES, TYPESHED]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update DEFAULT_COMMANDS below to not include this (or maybe get rid of it, since it's super error-prone, and use a flag here or something).

# Mypyc tests that aren't run by default, since they are slow and rarely
# fail for commits that don't touch mypyc
'mypyc-extra': 'pytest -k "%s"' % ' or '.join(MYPYC_OPT_IN),
Expand All @@ -88,7 +90,7 @@
# Stop run immediately if these commands fail
FAST_FAIL = ['self', 'lint']

DEFAULT_COMMANDS = [cmd for cmd in cmds if cmd != 'mypyc-extra']
DEFAULT_COMMANDS = [cmd for cmd in cmds if cmd not in ('mypyc-extra', 'typeshed-ci')]

assert all(cmd in cmds for cmd in FAST_FAIL)

Expand Down