[mypyc] Simplify IR for tagged integer comparisons #9607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the number of ops and registers typically by two. This also makes it easier to generate good code in a custom backend.
We could also do this for lhs, but it's less common.
TH3CHARLie
approved these changes
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a conditional context, such as in an if condition, simplify the
IR for tagged integer comparisons. Also perform some additional
optimizations if an operand is known to be a short integer.
This slightly improves performance when compiling with no
optimizations. The impact should be pretty negligible otherwise.
This is a bit simple-minded, and some further optimizations are
possible. For example,
3 < x < 6could be made faster. Thiscovers the most common cases, however.
Closes mypyc/mypyc#758.