Fix partial type crash during protocol checking #9495
Conversation
In particular, this affected hashables.
test-data/unit/check-protocols.test
Outdated
|
|
||
|
|
||
| [case testPartialTypeProtocolHashable] | ||
| # flags: --strict-optional |
There was a problem hiding this comment.
Do you need this? I thought it was the default. Or are the tests run multiple times with different default flags?
There was a problem hiding this comment.
Oh, I meant to use --no-strict-optional as in #9437 (comment) — but a test a couple lines up used --strict-optional and I copied it by accident. Thanks!
Hmm. It actually looks like --no-strict-optional is the default in tests. I just discovered this file lurking in the shadows:
Line 8 in 8bf770d
Also object in the test stubs doesn't have __hash__... so this test didn't actually test anything different from Blooper (and crashes regardless of --strict-optional). Fixed now (ie, the new test and old code only crashes with --no-strict-optional).
This test case was meant to use `--no-strict-optional`, not `--strict-optional`, but happened to crash anyway because object in the test stubs doesn't have __hash__. Both changes made.
In particular, this affected hashables. Fixes #9437 Co-authored-by: hauntsaninja <>
In particular, this affected hashables, as in #9437
Maybe there's a more standard way of falling back the PartialType? We could also consider moving this logic into is_subtype, but I'd be hesitant to do so. I'm okay with returning False based on the fallback Instance constructed here, but not returning True.