Update int_pow test to match new overloads in typeshed #9415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for both of the PRs! |
hauntsaninja
added a commit
that referenced
this pull request
Sep 5, 2020
This reverts commit bbd6677.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, python/typeshed#4473 is approved but fails the mypy self tests. This updates the
cmdline.testfile to match the new error message with overloads. Though, I'm sorta wondering if it would be less fragile to just not do this specific check at all.Feel free to take this (and the other PR) whenever it's least annoying to merge both together. Or, let me know if I'm missing something. 🙂
cc @JelleZijlstra