Skip to content

Pass module-specific Options to fastparse.parse() #9247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2020
Merged

Pass module-specific Options to fastparse.parse() #9247

merged 1 commit into from
Aug 3, 2020

Conversation

gvanrossum
Copy link
Member

Before this, per-module flags that are handled in fastparse (in
particular no_implicit_optional) were seeing the flag's global value.

Fixes #9208

@gvanrossum
Pass module-specific Options to fastparse.parse()
98f8b96 
Before this, per-module flags that are handled in fastparse (in
particular no_implicit_optional) were seeing the flag's global value.

Fixes #9208
JukkaL
JukkaL approved these changes Aug 3, 2020
View reviewed changes
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! The underlying issue was a pretty bad one, as it makes it harder to type check code bases that merge code from multiple sources. Looks good.

@JukkaL JukkaL merged commit 21e160e into master Aug 3, 2020
@gvanrossum gvanrossum deleted the pass-per-module-options-to-fastparse branch August 3, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use an implicit-optional library in a no_implicit_optional codebase
2 participants
@gvanrossum @JukkaL