Skip to content

Dialect #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Dialect #887

wants to merge 2 commits into from

Conversation

o11c
Copy link
Contributor

@o11c o11c commented Oct 1, 2015

I've pulled this out of #880 because it promises to be useful for #884 and #732

@o11c
Copy link
Contributor Author

o11c commented Oct 9, 2015

On further thought, I should separate out mypy-codec, mypy-stub, and add mypy-string for lexing the interior of string type annotations.

@o11c
Copy link
Contributor Author

o11c commented Oct 10, 2015

Expected usage:

  • From the command-line tool:
    • Add a --python-executable option (do this after driver so that it's all in mypy.main instead of scripts/mypy), store its argument in a python_executable variable.
    • set force_py2 = True if the --py2 flag is passed, for backward compatibility, but deprecate --py2.
    • python_implementation = dialect.Implementation(python_executable) if python_executable is not None else dialect.default_implementation(force_py2=force_py2)
    • Deprecate the --use-python-path option since we can now use it correctly even in python2 mode.
  • From the testsuite, see Improve test coverage of the Python2 bits of mypy #732, which I am increasingly convinced needs to be done before syntax, for testsuite reasons.

@o11c o11c closed this Oct 13, 2015
@o11c o11c deleted the dialect branch October 13, 2015 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant