TypedDict: update test for changes to keys, values, items #8104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of TypedDict's keys, values, items will be updated in typeshed in: python/typeshed#3529 The relevant issue is: python/typeshed#3473 That PR fails testTypedDictMappingMethods https://travis-ci.org/python/typeshed/builds/621439570 Tested by using my patched version of typeshed: ln -sf ~/typeshed mypy/typeshed pytest -n0 -k testTypedDictMappingMethods
|
Note the CI failure is expected since we'd need python/typeshed#3529 to be merged for tests to successfully run. |
msullivan
approved these changes
Jan 9, 2020
|
@JelleZijlstra do you want to do the typeshed merge stuff? |
|
Yes, I'll take care of this. |
|
Gentle ping on this, @JelleZijlstra |
Merged
|
Sorry for that! I'm performing all the required merges and syncs now, typeshed and mypy CI should be back to green shortly. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of TypedDict's keys, values, items will be updated in
typeshed in:
python/typeshed#3529
The relevant issue is:
python/typeshed#3473
That PR fails testTypedDictMappingMethods
https://travis-ci.org/python/typeshed/builds/621439570
Tested by using my patched version of typeshed:
ln -sf ~/typeshed mypy/typeshed
pytest -n0 -k testTypedDictMappingMethods