Fix type inference regression with partial types #8091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not ready to merge -- there seems to a problem with this PR. |
ilevkivskyi
approved these changes
Dec 5, 2019
mypy/checker.py
Outdated
| if is_valid_inferred_type(rvalue_type): | ||
| var.type = rvalue_type | ||
| else: | ||
| var.type = self.inference_error_fallback_type(rvalue_type) |
There was a problem hiding this comment.
What if one just assigns the variable twice (without reading it), would it silence the error on first assignment? Not that it is too bad, but still may be surprising.
There was a problem hiding this comment.
Yeah, a good catch! This behavior is inconsistent. I'll try to fix it.
mypy/checker.py
Outdated
| @@ -2785,6 +2788,7 @@ def infer_variable_type(self, name: Var, lvalue: Lvalue, | |||
| init_type = get_proper_type(init_type) | |||
| if isinstance(init_type, DeletedType): | |||
| self.msg.deleted_as_rvalue(init_type, context) | |||
| name.type = AnyType(TypeOfAny.from_error) | |||
There was a problem hiding this comment.
No, and this is kind of an unrelated thing that I encountered when trying a different fix. I might take this out of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't infer types such as
List[<nothing>]; inferList[Any]instead.Fixes #8090.