Skip to content

Remove interpreted_plugin.py and all its machinery! #8028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

msullivan
Copy link
Collaborator

Now that mypyc supports interpreted subclasses, we can eliminate this
long-winded and frumious hack.

Now that mypyc supports interpreted subclasses, we can eliminate this
long-winded and frumious hack.
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sure is nice to not need this hack any more.

Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big +1 from me! Great to see this not needed anymore.

Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ilevkivskyi ilevkivskyi merged commit f6e250d into master Nov 28, 2019
@ilevkivskyi ilevkivskyi deleted the kill-interpreted_plugin branch November 28, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants