Skip to content

Make tests use \[ to escape brackets instead of [[ #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

msullivan
Copy link
Collaborator

The main motivation here (though I also just like it more) is that
editor indentation modes won't get confused by unnested brackets when
editing test files in python-mode, which I do all the time.

The main motivation here (though I also just like it more) is that
editor indentation modes won't get confused by unnested brackets when
editing test files in python-mode, which I do all the time.
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that this looks better.

It looks like 99% of the changes were [mypy] headers containing in mypy.ini files...

@msullivan msullivan merged commit 475148f into master Sep 16, 2019
@msullivan msullivan deleted the test-bracket-escape branch September 16, 2019 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants