Work around crash caused by mypyc/mypyc#695 #7475
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypyc has some issues when shadowing variables in a list comprehension so work around it for now. This only affects mypyc when compiled with mypyc.
ilevkivskyi
approved these changes
Sep 5, 2019
|
I think I'm going to put up a diff to actually fix the bug instead of merging this, though. |
|
(The bug is in mypy itself actually) |
|
OK, as you prefer. |
|
Superseded by #7476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypyc has some issues when shadowing variables in a list comprehension
so work around it for now. This only affects mypyc when compiled with
mypyc.