Fix crash when a dataclass with a no init InitVar is inherited #7390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Aug 26, 2019
mypy/plugins/dataclasses.py
Outdated
| if info[attr.name].type is None: | ||
| try: | ||
| node = info[attr.name] | ||
| except KeyError: |
There was a problem hiding this comment.
I think that it would be slightly cleaner if you'd use a if info.get(attr.name) is None check instead of try/except here.
mypy/plugins/dataclasses.py
Outdated
| del info.names[attr.name] | ||
| try: | ||
| del info.names[attr.name] | ||
| except KeyError: |
There was a problem hiding this comment.
Similar to above, I'd slightly prefer an if statement instead of try/except here.
|
Thanks for the review! I updated the code and added a test. |
JukkaL
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7320.