Consider fallback instance promotions in is_overlapping_types() #7358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael0x2a
approved these changes
Aug 16, 2019
| # First we need to handle promotions and structural compatibility for instances | ||
| # that came as fallbacks, so simply call is_subtype() to avoid code duplication. | ||
| if (is_subtype(left, right, ignore_promotions=ignore_promotions) | ||
| or is_subtype(right, left, ignore_promotions=ignore_promotions)): |
There was a problem hiding this comment.
It's somewhat unfortunate we end up needing to perform a subtype check again here (we already call is_proper_subtype earlier in the method).
But as you said, it doesn't seem like there's a clean way of working around this without repeating some of the promotion logic anyways...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this opportunity I also made a tiny refactoring to avoid code duplication (that would grow even bigger if I would also add logic for promotions).