Report precision stats for imports and add new precision report #7254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Jul 24, 2019
mypy/report.py
Outdated
| return True | ||
| if path.startswith('..'): | ||
| return True | ||
| if 'stubs' in path.split('/'): |
mypy/report.py
Outdated
|
|
||
| file_info = FileInfo(path, tree._fullname) | ||
| for lineno, _ in iterate_python_lines(path): | ||
| print(repr((lineno, _))) |
mypy/report.py
Outdated
| output_files = sorted(self.files, key=lambda x: x.module) | ||
| report_file = os.path.join(self.output_dir, 'lineprecision.txt') | ||
| width = max(4, max(len(info.module) for info in output_files)) | ||
| fmt = '{:%d} {:5} {:7} {:9} {:3} {:5} {:10}\n' % width |
There was a problem hiding this comment.
Maybe generate the width numbers here and below from the list of column headers instead of putting them in as magic numbers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when reporting per-line type checking precision, imports were
treated as empty lines, which seems inconsistent. Now treat an import as
precise if the target module exists, and as imprecise if the target module is
missing from the build.
Also add a new report,
lineprecision, which is mostly designed to be usedin tests. The output is more compact and cleaner than the existing
XML-based reports.
Make it possible to run report generation tests without using full stubs,
since using full stubs is slow.
This is still not quite perfect. If using module-level
__getattr__, the importshould probably be treated as imprecise. Also, if a missing name is ignored
using
# type: ignore, we may want to treat that as imprecise. For multi-lineimports, we only report precision for the first line. These would be a bit tricky
to fix in the report generator so I decided to skip these for now.