Fix bad html report bug #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ouch, that was a nasty bug. Thanks for fixing it! Yeah, there should be test cases for HTML report generation. The report generator hasn't received a lot of love recently -- it was originally a quick hack and I haven't really touched it since. |
|
It might be saner to rewrite report generation to "output" (even if not on disk) XML, then use XSLT to generate the HTML. This would require adding a dependency on |
|
Note for posterity, I did the XSLT thing in #713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, HTML reports were horribly broken. The stub
.pyifiles for the standard library would be overwritten with the html report for the same file, so mypy could only run once.This fixes both of the bugs that let that happen.
There should probably be a testcase to make sure this sort of things would not happen again.