New semantic analyzer: track line numbers of placeholders #6983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line numbers are used sometimes to decide when a name should be looked up from an outer scope, so they should be set for placeholders. This actually breaks some forward references to assignment-based named tuples. The reason is that we don't set `becomes_typeinfo=True` for the placeholders. I'm going to open a separate issue about this, as it's an existing issue and this change only exposes it. Fixes #6949.
ilevkivskyi
approved these changes
Jun 13, 2019
I think that the named tuple issue is lower priority, since forward references to named tuples aren't supported on the old semantic analyzer, so it's not a regression. Also, the fix may be quite involved and may involve changing how other things such as type aliases and NewTypes are processed. |
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
Line numbers are used sometimes to decide when a name should be looked up from an outer scope, so they should be set for placeholders. This actually breaks some forward references to assignment-based named tuples. The reason is that we don't set `becomes_typeinfo=True` for the placeholders. I'm going to open a separate issue about this, as it's an existing issue and this change only exposes it. Fixes python#6949.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line numbers are used sometimes to decide when a name should be looked
up from an outer scope, so they should be set for placeholders.
This actually breaks some forward references to assignment-based named
tuples. The reason is that we don't set
becomes_typeinfo=Trueforthe placeholders. I'm going to open a separate issue about this, as
it's an existing issue and this change only exposes it.
Fixes #6949.