Use level "note" for reveal_type and reveal_locals #6919
Conversation
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
In principle I like this change (you can also indent revealed locals as discussed in the issue). But this is changes huge amount of tests, so I think this requires approval from most of core team members.
|
Great.
Ok, no hurry - I can see that this might cause trouble with pending PRs etc. |
As for this: do you think prepending " - " is good here? |
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
I like this change. It may be worth coordinating when to merge this as this goes stale quickly.
blueyed
changed the title
I think just four spaces offset is enough (like in protocol error message notes) |
|
Ok, updated and rebased. |
|
Sure! If you rebase it again I'll merge it. |
- sed -i 's/# E: Revealed type/# N: Revealed type/g' test-data/**/*.test - sed -i 's/: error: Revealed type/: note: Revealed type/g' test-data/**/*.test
|
@msullivan |
Tests were fixed using: - sed -i 's/# E: Revealed type/# N: Revealed type/g' test-data/**/*.test - sed -i 's/: error: Revealed type/: note: Revealed type/g' test-data/**/*.test Fixes #6901.
Tests were fixed using: - sed -i 's/# E: Revealed type/# N: Revealed type/g' test-data/**/*.test - sed -i 's/: error: Revealed type/: note: Revealed type/g' test-data/**/*.test Fixes python#6901.
Update mypy output parser for python/mypy#6919
5 participants
Fixes #6901.
TODO:
reveal_locals