Skip to content

Display note when having invariants in Union #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2019
Merged

Display note when having invariants in Union #6877

merged 3 commits into from
May 21, 2019

Conversation

remilapeyre
Copy link
Contributor

Fix #5895

gvanrossum
gvanrossum reviewed May 21, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style nit, otherwise this fits the bill!

gvanrossum
gvanrossum approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will merge this once the tests pass.

@gvanrossum gvanrossum merged commit b406de7 into python:master May 21, 2019
PattenR pushed a commit to PattenR/mypy that referenced this pull request Jun 23, 2019
@PattenR
Display note when having invariants in Union (python#6877)
8ffff06 
Fixes python#5895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error feedback for unions of lists that should be unions of sequences is not as helpful as it could be
2 participants
@remilapeyre @gvanrossum