Fix reporting of likely hangs in the new semantic analyzer #6872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously things like `class A(A): pass` resulted in a crash instead of an error message. Now we generate an error message with some context (but still not enough). Partially addresses #6495.
ilevkivskyi
approved these changes
May 21, 2019
Probably yes? I'll create another PR to fix that. |
JukkaL
added a commit
that referenced
this pull request
May 21, 2019
Fix another crash related to hitting max iteration count in the new semantic analyzer.
JukkaL
added a commit
that referenced
this pull request
May 21, 2019
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
Previously things like `class A(A): pass` resulted in a crash instead of an error message. Now we generate an error message with some context (but still not enough). Partially addresses python#6495.
PattenR
pushed a commit
to PattenR/mypy
that referenced
this pull request
Jun 23, 2019
Fix another crash related to hitting max iteration count in the new semantic analyzer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously things like
class A(A): passresulted in a crashinstead of an error message. Now we generate an error message
with some context (but still not enough).
Partially addresses #6495.