Fix interaction of isinstance() with Type[...] #6419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4616
Fixes #6416
Fixes #6386
Currently
Type[C]
is considered a subtype of metaclass ofC
, and I think this is right. The idea is to fixProperSubtypeVisitor.visit_type_type()
to matchSubtypeVisitor.visit_type_type()
(plus couple small updates to make the former used byisinstance()
andissubclass()
).