Skip to content

Default to wait forever with Windows IPC #5976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2018
Merged

Default to wait forever with Windows IPC #5976

merged 1 commit into from
Nov 30, 2018

Conversation

emmatyping
Copy link
Member

This is to hopefully fix flakes when running tests in slow CI...

@emmatyping emmatyping requested a review from msullivan November 30, 2018 08:01
msullivan
msullivan approved these changes Nov 30, 2018
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in any case, it harmonizes the behavior with unix.

If we still see flakes, we'll have to result to plan B and actually think about it some more. :(

@msullivan
Copy link
Collaborator

Well that didn't work.

@emmatyping emmatyping merged commit 4f6db54 into python:master Nov 30, 2018
@emmatyping emmatyping deleted the waitforever branch November 30, 2018 08:30
@emmatyping
Copy link
Member Author

note: merging even though it didn't fix the problem because as Sully said, it makes Windows more in line with Unix.

I'm currently trying to debug what is actually going wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmatyping @msullivan