Add some workarounds to simplify bootstrap #5614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
reviewed
Sep 13, 2018
mypy/checker.py
Outdated
| if (isinstance(base_attr_node, (Var, FuncBase, Decorator)) | ||
| and base_attr_node.is_final): | ||
| if (isinstance(base_attr.node, (Var, FuncDef, OverloadedFuncDef, Decorator)) | ||
| and base_attr.node.is_final): |
There was a problem hiding this comment.
Looks like this exact check gets repeated four times. I think that it would be worth turning it into a utility function, such as is_final_node().
There was a problem hiding this comment.
Yes, it compiles well, and passes self-check. Also I did the refactoring.
JukkaL
approved these changes
Sep 13, 2018
ilevkivskyi
added a commit
that referenced
this pull request
Sep 13, 2018
This reverts commit 4a574c2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.