CI upgrades #5417
Merged
CI upgrades #5417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gaborbernat
commented
Aug 2, 2018
gaborbernat
commented
- Travis test with python3.7 and python3.8-dev
- Travis use tox to setup/run tests
- Bump tox default envs from python3.6 to python3.7
- Travis test with python3.7 and python3.8-dev - Travis use tox to setup/run tests - Bump tox default envs from python3.6 to python3.7
|
This looks great! |
emmatyping
reviewed
Aug 3, 2018
.travis.yml
Outdated
| - python: 3.6 # 3.6.3 pip 9.0.1 | ||
| - python: 3.7 # 3.7.0 pip 10.0.1 | ||
| - python: 3.8-dev | ||
| - python: 3.7 |
There was a problem hiding this comment.
Might you be able to add names to the lint and self check runs? (see https://docs.travis-ci.com/user/customizing-the-build/#naming-jobs-within-matrices). Having 3 "3.7" environments could be a bit confusing :)
.travis.yml
Outdated
| language: python | ||
| # cache package wheels (1 cache per python version) | ||
| cache: pip | ||
| python: | ||
| - "3.4" | ||
| dist: xenial |
There was a problem hiding this comment.
While I know why xenial is needed for some of these runs, it would be nice to leave a short comment for the future.
|
Done requested changes. |
|
@gaborbernat lxml doesn't have any Windows wheels yet, so I would revert the last commit. |
|
But somehow it downloads a wheel on other PRS (^^)
…On Sat, Aug 4, 2018, 03:20 Ethan Smith ***@***.***> wrote:
@gaborbernat <https://github.com/gaborbernat> lxml doesn't have any
Windows wheels yet, so I would revert the last commit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5417 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAqIPgKIVbhSV4___RG_ox9xUMvwhZmPks5uNQTqgaJpZM4VsofC>
.
|
|
Sorry let me correct myself. lxml doesn't have wheels for 3.7 on Windows yet. It works otherwise because we are targeting 3.6 currently. |
|
oh then I can just revert to 3.6 ^_^
…On Sat, Aug 4, 2018, 09:12 Ethan Smith ***@***.***> wrote:
Sorry let me correct myself. lxml doesn't have wheels for *3.7* on
Windows yet. It works otherwise because we are targeting 3.6 currently.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5417 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAqIPosI8v0StHahQHBU48vDVMMvbJENks5uNVdegaJpZM4VsofC>
.
|
|
actually turns out the latest minor has it so bumped to that |
|
@ethanhs now should be all ok 👍 |
Wow, they just uploaded the 3.7 Windows wheels yesterday! Your timing is impeccable :) |
emmatyping
approved these changes
Aug 4, 2018
MatthieuDartiailh
added a commit
to MatthieuDartiailh/atom
that referenced
this pull request
Aug 6, 2018
Based on what is now done in mypy: python/mypy#5417
MatthieuDartiailh
added a commit
to MatthieuDartiailh/kiwi
that referenced
this pull request
Aug 6, 2018
MatthieuDartiailh
added a commit
to nucleic/kiwi
that referenced
this pull request
Aug 6, 2018
* Add testing for Python 3.7 * travis: see if dist: xenial allow python 3.7 to run * travis: try to use sudo: required and follow mypy recipe python/mypy#5417
MatthieuDartiailh
added a commit
to nucleic/atom
that referenced
this pull request
Sep 20, 2018
* Add testing for Python 3.7 * travis: try to use different distributions based on python version Based on what is now done in mypy: python/mypy#5417 * travis: try setting sudo to required and use pip cache * atomlist: hack around Python 3.7 fastcall protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.