Skip to content

Sync typeshed #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2018
Merged

Sync typeshed #5327

merged 3 commits into from
Jul 7, 2018

Conversation

ilevkivskyi
Copy link
Member

In preparation for the release.

gvanrossum
gvanrossum approved these changes Jul 6, 2018
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if this necessitates any changes to Dropbox code bases?

@ilevkivskyi
Copy link
Member Author

Did you check if this necessitates any changes to Dropbox code bases?

Testing now, but apparently we have another problem (see test failures). I am looking into it.

@ilevkivskyi
Copy link
Member Author

OK, the failures are because of recently added Windows platform checks.

@gvanrossum
Copy link
Member

Maybe when we run stdlib-samples we should force the platform to linux.

@ilevkivskyi
Copy link
Member Author

All checks were added in python/typeshed@1ae2ba0

Maybe when we run stdlib-samples we should force the platform to linux.

Self-check also fails. Because daemon is not supported on Windows yet. testpr is not done yet, but I remember there were some problems on C when we last attempted using platform checks in typeshed.

@ilevkivskyi
Copy link
Member Author

Actually not so many errors internally, I will try to fix the mypy self-check and samples.

@gvanrossum
Copy link
Member

LMK if you need another approval.

@ilevkivskyi
Copy link
Member Author

LMK if you need another approval.

Are you OK with the change in dmypy_server.py? (Other changes are trivial.)

gvanrossum
gvanrossum approved these changes Jul 7, 2018
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you OK with the change in dmypy_server.py?

Yes, on Windows it would just crash with an AttributeError a few lines down at os.fork().

@ilevkivskyi ilevkivskyi merged commit 39d8eee into python:master Jul 7, 2018
@ilevkivskyi ilevkivskyi deleted the sync-typeshed-111 branch July 7, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilevkivskyi @gvanrossum