Skip to content

Fix crash caused by protocols-promote interference #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2018
Merged

Fix crash caused by protocols-promote interference #5297

merged 2 commits into from
Jul 1, 2018

Conversation

ilevkivskyi
Copy link
Member

Fixes #5291

@ilevkivskyi ilevkivskyi requested a review from msullivan June 29, 2018 17:11
msullivan
msullivan approved these changes Jun 29, 2018
View reviewed changes
Copy link
Collaborator

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is it worth documenting why it needs to be this way?

@emmatyping
Copy link
Member

Is it worth documenting why it needs to be this way?

I think since the previous implementation had an issue with this, mentioning it somewhere might be nice.

emmatyping
emmatyping approved these changes Jul 1, 2018
View reviewed changes
Copy link
Member

@emmatyping emmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ilevkivskyi ilevkivskyi merged commit c77e27a into python:master Jul 1, 2018
@ilevkivskyi ilevkivskyi deleted the fix-protocol-crash branch July 1, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msullivan msullivan msullivan approved these changes

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilevkivskyi @emmatyping @msullivan