Allow __getattr__ during semantic analysis #5295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Jun 29, 2018
mypy/semanal.py
Outdated
| v = Var(name, type=typ) | ||
| v._fullname = name | ||
| n = SymbolTableNode(GDEF, v) | ||
| names[name] = n |
There was a problem hiding this comment.
It might be worth pulling this out into another method, since it is a big chunk of code for an obscure case.
There was a problem hiding this comment.
Makes sense. I there is also similar code above in visit_import_from, it would make sense to combine the two into a helper method. I will do this tomorrow.
Yes. I am slowly moving through existing stubs and trying to combine them with some |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously module
__getattr__was used during type checking (runtime context). But it was only partially allowed in semantic analysis (afterfrom a import A,Acan be used in annotations/base classes). This PR allows the same support fora.A, i.e. it can be used in annotations and base classes (provided__getattr__has a suitable return typeAny).