Make overload impl checks correctly handle TypeVars and untyped impls #5236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request fixes python#4619 as well as an unrelated bug where if the overload implementation was untyped, we only check to see if there are unsafe overlaps between the *first* overload alternative and the rest.
Michael0x2a
force-pushed
the
fix-overloads-impl-checks
branch
from
69b06a5 to
2d604fa
Compare
ilevkivskyi
reviewed
Jun 25, 2018
mypy/checker.py
Outdated
| is_compat=is_subtype, | ||
| ignore_return=True): | ||
| ignore_return=True, | ||
| unify_generics=False): |
There was a problem hiding this comment.
This function has already too many arguments. Is there a way to avoid unify_generics? Like if you already unified above, the unification in is_callable_compatible will be a no-op?
There was a problem hiding this comment.
Huh, that's weird. I could have sworn we needed this parameter, but I tried removing it and everything still worked. Maybe it was a holdover from one of my previous attempts at tackling the bug?
Anyways, I updated the PR to remove this param. Regarding the number of arguments: I'm planning on refactoring and splitting up is_callable_compatible in the upcoming PR for improving error messages -- that should help us cut down on the number of params/ad-hoc special casing.
ilevkivskyi
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #4619 as well as an unrelated bug where if the overload implementation was untyped, we only check to see if there are unsafe overlaps between the first overload alternative and the rest.