Make pep561 tests parrallel and sandboxed #5060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each test is run in a seperate virtualenv which is deleted after the tests. This means they can be run in parrallel, and caused about a 30% speedup on my machine (4x parrallel). This also will allow for the tests to scale better with egg support, and bypass issues with uninstalling some types of packages.
emmatyping
changed the title
emmatyping
changed the title
|
This is ready for review now. It isn't as important as I decided egg support serves little purpose, but it provides a nice speedup, and makes things cleaner. |
|
I just realized I might have been a bit vague in my last message. I'm hoping to get this merged soonish so that I can work on adding support for editable installs of packages (which I already have an implementation of), then support for partial stub packages. If someone finds the time I'd appreciate a review. |
ilevkivskyi
reviewed
Jun 15, 2018
mypy/test/testpep561.py
Outdated
| '-y', pkg], cwd=package_path) | ||
| if returncode != 0: | ||
| self.fail('\n'.join(lines)) | ||
| yield |
There was a problem hiding this comment.
I am not sure what is the benefit of context manager which has yield as a last statement. Can't be this just made a function?
There was a problem hiding this comment.
Good point. I will refactor things into just using this as a function.
ilevkivskyi
approved these changes
Jun 15, 2018
ilevkivskyi
pushed a commit
that referenced
this pull request
Jun 17, 2018
When working on partial stub packages I realized that the changes in #5060 were flaking. This change runs mypy in each temporary directory, which avoids parrallelism/cache issues (sometimes the multiple processes would try to read/write the same cache file). To test this thoroughly, I ran the test 25 times in a row, with no failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each test is run in a seperate virtualenv which is deleted after the
tests. This means they can be run in parrallel, and caused about a 2x
speedup for pep561 on my machine (4x parrallel). This also will allow for the tests
to scale better with egg support, and bypass issues with uninstalling
some types of packages.