Cache package names in create_source_list #4848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
requested changes
Apr 3, 2018
mypy/find_sources.py
Outdated
|
|
||
| parent_dir, base = os.path.split(dir) | ||
| if not dir or not get_init_file(fscache, dir) or not base: | ||
| return '' |
There was a problem hiding this comment.
So this result should not be cached?
gvanrossum
reviewed
Apr 4, 2018
mypy/find_sources.py
Outdated
| mod = base | ||
| else: | ||
| mod = base + '.' + mod | ||
| Use package_cache to cache results.""" |
There was a problem hiding this comment.
Move the """ to the next line (by itself). There's no need for a subsequent blank line then.
mypy/find_sources.py
Outdated
|
|
||
| def expand_dir(self, arg: str, mod_prefix: str = '') -> List[BuildSource]: | ||
| """Convert a directory name to a list of sources to build.""" | ||
| f = get_init_file(self.fscache, arg) |
There was a problem hiding this comment.
Perhaps make get_init_file() also a method here? (Since it uses fscache.)
gvanrossum
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my testing MBP, this shaves about 200ms off of every fine-grained check of S.