Made local type vars in stubs private #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spkersten
changed the title
spkersten
force-pushed
the
privstub452
branch
from
6985e82 to
b6a4307
Compare
|
It's still useful -- thanks for fixing these! Some modules will want to define type variables that should be visible outside the module, and we can use an underscore to distinguish those that should not be exported. |
JukkaL
added a commit
that referenced
this pull request
Sep 15, 2014
Made local type vars in stubs private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed the local type vars in the stubs to start with an underscore.
Resolves #452.