Skip to content

Do not warn on returning any from deferred node #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2017
Merged

Do not warn on returning any from deferred node #4295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a453a
do not warn on returning any from deferred node
elazarg Nov 30, 2017
69a678b
Remove empty lines
elazarg Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,7 +2133,7 @@ def check_return_stmt(self, s: ReturnStmt) -> None:
if isinstance(typ, AnyType):
# (Unless you asked to be warned in that case, and the
# function is not declared to return Any)
if (self.options.warn_return_any and
if (self.options.warn_return_any and not self.current_node_deferred and
not is_proper_subtype(AnyType(TypeOfAny.special_form), return_type)):
self.msg.incorrectly_returning_any(return_type, s)
return
Expand Down
12 changes: 12 additions & 0 deletions test-data/unit/check-warnings.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,3 +197,15 @@ class Test(object):
return None
[builtins fixtures/list.pyi]
[out]

[case testReturnAnyDeferred]
# flags: --warn-return-any
def foo(a1: A) -> int:
if a1._x:
return 1
n = 1
return n

class A:
def __init__(self, x: int) -> None:
self._x = x