Improvements to blocker handling in fine-grained incremental mode, etc. #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are useful with fine-grained incremental mode.
Make order of processing files more predictable.
gvanrossum
reviewed
Dec 1, 2017
mypy/server/update.py
Outdated
| ('remaining', List[Tuple[str, str]])]) | ||
|
|
||
| # The result of update_single_isolated when there is a blocking error. Items | ||
| # are similar to NormalUpdate (but there are fewer). |
There was a problem hiding this comment.
I wonder if it makes sense to move remaining up in the list for NormalUpdate so that the first three items always have the same meaning?
mypy/server/update.py
Outdated
| @@ -316,7 +372,9 @@ def delete_module(module_id: str, | |||
| # TODO: Deletion of a package | |||
| # TODO: Remove deps for the module (this only affects memory use, not correctness) | |||
| new_graph = graph.copy() | |||
| del new_graph[module_id] | |||
| if module_id in new_graph: | |||
| # TODO: Why would this ever be reached? | |||
There was a problem hiding this comment.
What if you replace it with assert module_id not in new_graph?
gvanrossum
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle various additional cases of blocking errors. This also contains a fair
amount of refactoring.