Extract typeddict semantic analysis from to a separate class #4114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elazarg
changed the title
|
I think this should happen after last strict-optional PR is merged. |
|
Makes sense. |
|
Note that I'm working on doing a similar extraction for named tuple. Mine is a little different -- it moves the new class into a new module in a way that there is no import cycle. |
elazarg
force-pushed
the
extract-typeddict-analyzer
branch
from
a2c39c8 to
a959f80
Compare
|
This PR can't be maintained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4083.
The intention is to do the same thing to namedtuple and enum, then move them to a separate module, refactor common work to helper functions, and hopefully find the right abstraction so it will be easy to add plugins of this kind.