Skip to content

Conversation

@JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Sep 18, 2017

No description provided.

@JukkaL JukkaL requested a review from gvanrossum September 18, 2017 13:32
## September-December 2017

- Fix remaining highest-priority TypedDict issues and make TypedDict
an officially supported mypy feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it is planned to move TypedDict to typing? There are still some bugs with TypedDict, but it seems to be "feature complete".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this in Python 3.7 there should be a PEP (since it is a significant feature). But I think it's better to keep it in typing_extensions, so we can iterate on the feature more quickly. E.g. maybe we end up needing per-field flags for totality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think it's better to keep it in typing_extensions

It is currently only in mypy_extensions (as well as extended Callable arguments). Maybe it actually makes sense to move these to typing_extensions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably debate that on the typing tracker. The difference between the two is that things in mypy_extensions can be unilaterally added or changed by the mypy team, and may forever remain mypy-specific, while things in typing_extensions need to be debated with the other projects using PEP 484 (e.g. PyCharm and pytype) and must be intended for eventual inclusion in typing.py.

@gvanrossum gvanrossum merged commit c000062 into master Sep 18, 2017
@gvanrossum gvanrossum deleted the update-roadmap branch September 18, 2017 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants