Fix per-file strict Optional interaction with default-None args #3686
Conversation
Helpful for the right fix in #3686.
|
@gvanrossum this should be ready to review now! |
| strict_optional = False | ||
| [[mypy-optional] | ||
| strict_optional = True | ||
|
|
There was a problem hiding this comment.
You don't really need three blank lines here, just one. :-) Also IMO you can drop the single blank lines above.
There was a problem hiding this comment.
Fixed the three blank lines. The lines between the files make them much more readable to me (though it looks like one got dropped, so I added it back).
| @@ -363,7 +363,7 @@ y = x # E: Incompatible types in assignment (expression has type Callable[..., | |||
|
|
|||
| a, b = None, None # type: (A, B) | |||
| a = f() # E: Incompatible types in assignment (expression has type "B", variable has type "A") | |||
| b = f(b) # E: Argument 1 to "f" has incompatible type "B"; expected "A" | |||
| b = f(b) # E: Argument 1 to "f" has incompatible type "B"; expected "Optional[A]" | |||
There was a problem hiding this comment.
I wonder if it makes more sense to change the definition of f() to use A() as the default value? Ditto for the next test below.
There was a problem hiding this comment.
It looks to me like those functions are partially testing forward references? (Not sure why they'd be structured like that otherwise.) I can't use A() when it's a forward reference.
There was a problem hiding this comment.
Hm, I think that's just how Jukka used to write tests, with the classes/functions at the end. A lot of them have that. Anyway I'll merge now!
|
Should be cherry-picked into 0.521. |
Helpful for the right fix in python#3686.
…on#3686) With per-file strict Optional, default-None args should always be interpreted as Optional (except with --no-implicit-optional), instead of only in strict Optional files.
With per-file strict Optional, default-None args should always be interpreted as Optional (except with
--no-implicit-optional), instead of only in strict Optional files.