Add a flag to ignore the mypy version in cache metadata #3641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatyping
reviewed
Jul 1, 2017
| @@ -891,7 +891,7 @@ def find_cache_meta(id: str, path: str, manager: BuildManager) -> Optional[Cache | |||
| return None | |||
|
|
|||
| # Ignore cache if generated by an older mypy version. | |||
| if (m.version_id != manager.version_id | |||
| if ((m.version_id != manager.version_id and not manager.options.skip_version_check) | |||
There was a problem hiding this comment.
Minorest nit: The or clauses here break over a line, I think for consistency it'd be nice to do so with the and.
There was a problem hiding this comment.
I disagree, since and binds tighter and there is room.
There was a problem hiding this comment.
No worries, a style choice I suppose. Everything LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing cache improvement I'd like to be able to use cache files produced by a previous mypy version.