Fix overload resolution for metaclass #3511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elazarg
commented
Jun 8, 2017
test-data/unit/check-classes.test
Outdated
| reveal_type(f(e2)) # E: Revealed type is 'builtins.int' | ||
|
|
||
| [out] | ||
| main:6: error: An overloaded function outside a stub file must have an implementation |
There was a problem hiding this comment.
No, there must be an implementation (or make this in a .pyi file in test).
There was a problem hiding this comment.
This is not how overloads work. PEP 484:
In regular modules, a series of
@overload-decorated definitions must be followed by exactly one non-@overload-decorated definition
There was a problem hiding this comment.
OK, sorry. I will add one.
elazarg
force-pushed
the
metaclass-overload-res
branch
from
51a8443 to
ce309a9
Compare
JukkaL
requested changes
Jun 20, 2017
test-data/unit/check-classes.test
Outdated
| class EM(type): pass | ||
| class E(metaclass=EM): pass | ||
|
|
||
| @overload |
There was a problem hiding this comment.
It would be nice to have a few more test cases:
- Test two overload variants which have two different metaclasses as argument types, and overloading based on metaclass.
- Test calling the overloaded function with a
strargument (results should bestr).
JukkaL
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3452.