Fix undefined error line number #3420
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
May 23, 2017
| @@ -3327,7 +3327,10 @@ def name_not_defined(self, name: str, ctx: Context) -> None: | |||
| def name_already_defined(self, name: str, ctx: Context, | |||
| original_ctx: Optional[SymbolTableNode] = None) -> None: | |||
| if original_ctx: | |||
| extra_msg = ' on line {}'.format(original_ctx.node.get_line()) | |||
| if original_ctx.node and original_ctx.node.get_line() != -1: | |||
There was a problem hiding this comment.
IIUC the idea, then I would check for original_ctx.mod_id, and if it is not None then mention the module where original definition occurred. Otherwise, I would just set extra_msg = ''.
There was a problem hiding this comment.
(This comment belongs to the else: branch below.)
There was a problem hiding this comment.
We're trying to catch the cases where the definition is repeated twice in the same module, and indicate the line where the first one occurred. I don't think mod_id would ever be a different module if it gets to this line, right? It could be either None (when the definition was added from an import perhaps) or the same as the current module.
|
Closing this in favor of resubmitting the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3415
Sorry, I meant to check for
.node is None, but forgot.Please check if the message is ok in case the line info unavailable.