Add --include-private option to stubgen to include private members. #3367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
May 16, 2017
mypy/stubgen.py
Outdated
| except Exception as e: | ||
| if not options.ignore_errors: | ||
| raise e | ||
| else: | ||
| print("Stub generation failed for", module, file=sys.stderr) | ||
|
|
||
|
|
||
| def parse_options() -> Options: | ||
| args = sys.argv[1:] | ||
| def parse_options(args: Optional[List[str]] = None) -> Options: |
There was a problem hiding this comment.
Do I understand correctly that this signature change is needed only for tests?
There was a problem hiding this comment.
Correct. Would you prefer that I make args non-optional and pass sys.argv from main?
mypy/test/teststubgen.py
Outdated
| @@ -104,11 +104,20 @@ def cases(self) -> List[DataDrivenTestCase]: | |||
| return c | |||
|
|
|||
|
|
|||
| def parse_args(line: str) -> Options: | |||
| if line.startswith('# opts:'): | |||
There was a problem hiding this comment.
In other mypy tests this is called # flags:, so that it would be better to be consistent.
There was a problem hiding this comment.
Ah, thanks, I missed that. I'll update this to behave like the others.
ilevkivskyi
approved these changes
May 17, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found this option to be useful when generating stubs for some third party modules. It can also be useful when using stubs for internal use in place of comments annotations in python2. In this scenario, where stubs are used to type check their corresponding files, you can't omit members.