Fix crash due to deserialization of TypedDict type objects #3275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A TypeInfo attribute was not handled during fixup, causing a crash when using a TypedDict type imported from a deserialized module in an annotation. Fixes #3272.
JukkaL
added a commit
that referenced
this pull request
Apr 28, 2017
The test cases use a serialized module in incremental mode in various ways to make sure that all important information in the AST nodes is preserved during serialization and deserialization. These are all very straightforward. The idea is to help catch regressions early and to make it easier to refactor or optimize serialization code. These found 2 issues -- separated the first to PR #3275. The second issue (#3274) is still unfixed and there is a skipped test case for it. More complex cases such as import cycles will still go to check-incremental.test.
|
Appveyor failures seem to be flakes (access denied errors). |
Hopefully #3239 should fix that. But I feel the need to review it very carefully before merging it. This PR looks fine and I'm merging it now. |
JukkaL
added a commit
that referenced
this pull request
May 5, 2017
The test cases use a serialized module in incremental mode in various ways to make sure that all important information in the AST nodes is preserved during serialization and deserialization. These are all very straightforward. The idea is to help catch regressions early and to make it easier to refactor or optimize serialization code. These found 2 issues -- separated the first to PR #3275. The second issue (#3274) is still unfixed and there is a skipped test case for it. More complex cases such as import cycles can still go to check-incremental.test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A TypeInfo attribute was not handled during fixup, causing a crash when
using a TypedDict type imported from a deserialized module in an
annotation (when using
-i).Fixes #3272.