Update PY3 cheat sheet with varargs example. #3201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove an extraneous blank line from the PY2 sheet.
ilevkivskyi
reviewed
Apr 20, 2017
docs/source/cheat_sheet_py3.rst
Outdated
| # This is how to deal with varargs. | ||
| # This makes each positional arg and each keyword arg a 'str'. | ||
| def call(self, *args, **kwargs): | ||
| # type: (*str, **str) -> str |
There was a problem hiding this comment.
Why not just:
def call(self, *args: str, **kwargs: str) -> str:
...This seems to work equally well. Aren't we supposed to use Python 3 idioms/syntax in Python 3 cheat sheet?
There was a problem hiding this comment.
That had occurred to me too after pushing this, and through some fat-fingering I didn't push the fix. Now I have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove an extraneous blank line from the PY2 sheet.
(This was added for PY2 in #2524 but forgotten for PY3.)