-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Treat non-inplace augmented assignment as a simple assignment #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1514,3 +1514,10 @@ class A(): pass | |
class B(): pass | ||
[out] | ||
main:8: error: Incompatible types in assignment (expression has type "A", variable has type "B") | ||
|
||
[case testAugmentedAssignmentIntFloat] | ||
weight0 = 65.5 | ||
weight0 = 65 | ||
weight0 *= 0.5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test also case where there is an error due to invalid operand types for |
||
|
||
[builtins fixtures/float.pyi] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
Any = 0 | ||
|
||
class object: | ||
def __init__(self) -> None: pass | ||
|
||
class type: | ||
def __init__(self, x: Any) -> None: pass | ||
|
||
class str: | ||
def __add__(self, other: 'str') -> 'str': pass | ||
class bytes: pass | ||
|
||
class tuple: pass | ||
class function: pass | ||
|
||
class ellipsis: pass | ||
|
||
|
||
class int: | ||
def __float__(self) -> float: ... | ||
def __int__(self) -> int: ... | ||
def __mul__(self, x: int) -> int: ... | ||
def __rmul__(self, x: int) -> int: ... | ||
|
||
class float: | ||
def __float__(self) -> float: ... | ||
def __int__(self) -> int: ... | ||
def __mul__(self, x: float) -> float: ... | ||
def __rmul__(self, x: float) -> float: ... | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
reveal_type(weight0)
after each assignment.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I did it, I discovered another problem: I didn't update the binder (the last
weight0
should go back tofloat
, but it stayed asint
in my patch). I have fixed it by using a higher levelcheck_assignment
method instead of copying/pasting a line fromcheck_simple_assignment
. I think this way, the code has become cleaner overall since I could get rid of a couple lines from the original implementation ofvisit_operator_assignment_stmt
(they are taken care of in thecheck_assignment
call).