Skip to content

Conversation

ddfisher
Copy link
Collaborator

The new version of typed-ast supports all Python 3.6 syntax features. This unblocks #2622. The new version of typed_ast also supports type comments on async with and async for, support for which will be added in a subsequent PR.

@@ -27,7 +27,7 @@
from mypy.errors import Errors

try:
from typed_ast import ast35
from typed_ast import ast3 # type: ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing the typeshed stubs for typed_ast need an update? I can work on that if you're not already doing it.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just a process nit (we need to remember to update the stubs), and waiting for the failing test to be fixed. We also need to fix docs/source/python36.rst before releasing mypy 0.480.

@@ -120,7 +120,7 @@ def is_no_type_check_decorator(expr: ast3.expr) -> bool:
return False


class ASTConverter(ast3.NodeTransformer):
class ASTConverter(ast3.NodeTransformer): # type: ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a typeshed issue to upgrade the typed_ast stubs, and link this (and similer ignores later) to it?

@ddfisher
Copy link
Collaborator Author

Typeshed PR here: python/typeshed#931

@gvanrossum gvanrossum merged commit 3cc5201 into master Feb 13, 2017
@gvanrossum gvanrossum deleted the update-typed-ast branch February 13, 2017 15:29
@gvanrossum
Copy link
Member

Whee! I'll leave the typeshed sync and the removal of the ignores for a later PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants