Turn --warn-no-return on by default #2462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you fix the failing tests? |
|
Working on it! Got busy with other tasks right after submitting this. |
|
This generates a large number of errors in the Dropbox 'C' repo. Are you planning to use |
|
Thanks for double checking that! Yeah, I have a WIP diff to that repo to fix those -- the errors are legitimate. |
ddfisher
force-pushed
the
warn-no-return-default
branch
2 times, most recently
from
3d0df7f to
cd2606e
Compare
Fixes interaction with Generators. Fixes tests.
ddfisher
force-pushed
the
warn-no-return-default
branch
from
cd2606e to
8242c36
Compare
|
@JukkaL this should be mergeable now! |
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--warn-no-returnhas shown itself to be generally useful, and so far has had only minor bugs (which have been fixed) over hundreds of thousands of lines of code. This sort of check is pretty integral to correctness -- let's turn it on by default.