Support matrix multiplication operator (@) #2287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
requested changes
Oct 19, 2016
| @@ -182,6 +182,22 @@ main:3: error: Unsupported operand types for * ("A" and "C") | |||
| main:4: error: Incompatible types in assignment (expression has type "C", variable has type "A") | |||
| main:5: error: Unsupported left operand type for * ("B") | |||
|
|
|||
| [case testMatMul] | |||
|
|
|||
There was a problem hiding this comment.
Please go easy on the blank lines in unit tests. The files are long enough.
| @@ -182,6 +182,22 @@ main:3: error: Unsupported operand types for * ("A" and "C") | |||
| main:4: error: Incompatible types in assignment (expression has type "C", variable has type "A") | |||
| main:5: error: Unsupported left operand type for * ("B") | |||
|
|
|||
| [case testMatMul] | |||
There was a problem hiding this comment.
Don't we need separate tests for --fast-parser?
There was a problem hiding this comment.
I don't know. Do we? It already supports the operator. Looks like this work is delegated to typed_ast.
There was a problem hiding this comment.
I have added a test to verify that the fast parser recognizes the operator. As far as I understand there's nothing more to test there, not more than there is for any other operator.
gvanrossum
approved these changes
Oct 20, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #705
Added old parser support too.