-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Refactor: replace make_simplified_union with UnionType.make_union (#8624) #19026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…binder.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…checker.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…checkexpr.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…checkmember.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…checkpattern.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…erasetype.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…meet.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…plugins/attrs.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…plugins/ctypes.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…plugins/default.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…plugins/enums.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…semanal_shared.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
…typeops.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in typeops.py, as part of the codebase modernization and consistency improvements proposed in issue python#8624.
…suggestions.py (python#8624) This commit replaces all calls to make_simplified_union with UnionType.make_union in this file, as part of the codebase modernization effort in issue python#8624.
for more information, see https://pre-commit.ci
Okay, was this generated by some LLM? That's not the difference between |
This commit fixes code formatting issues automatically using `ruff --fix` and `black .` as recommended by the Mypy maintainers.
for more information, see https://pre-commit.ci
I'm closing this PR after realizing that UnionType.make_union is not a safe drop-in replacement for make_simplified_union. |
This PR replaces calls to
make_simplified_union
with the more modernUnionType.make_union
across several files, as part of the cleanup and modernization discussed in issue #8624.This change does not modify behavior but standardizes the way union types are created in the type system, improving code consistency.
Affected files: